-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22425/#review45881
-----------------------------------------------------------

Ship it!



include/mesos/mesos.proto
<https://reviews.apache.org/r/22425/#comment80953>

    s/Master/master/



include/mesos/mesos.proto
<https://reviews.apache.org/r/22425/#comment80954>

    s/i.e./i.e.,/



include/mesos/mesos.proto
<https://reviews.apache.org/r/22425/#comment80955>

    and Credential.principal (if using authentication) ?


- Vinod Kone


On June 17, 2014, 12:29 a.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22425/
> -----------------------------------------------------------
> 
> (Updated June 17, 2014, 12:29 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-1443
>     https://issues.apache.org/jira/browse/MESOS-1443
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 709b8b1ef4fee17c6a95c37f9ca6ea6ccc2a5daf 
>   src/master/flags.hpp 780e219e81e3df57da197784f67deab2b0de4382 
>   src/master/master.hpp 7a121856806ff2d79661fa31e491ddd6e4512c59 
>   src/master/master.cpp 4a01b1aacfff83c62aa2ec3b46ad64e631488d09 
> 
> Diff: https://reviews.apache.org/r/22425/diff/
> 
> 
> Testing
> -------
> 
> make check (tested along with https://reviews.apache.org/r/22427)
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Reply via email to