----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23246/#review47234 -----------------------------------------------------------
Ship it! src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/23246/#comment82869> Sentence is too long. How about s/container so that/container. This is important because/ s/but not/ but __not__/ <-- this is important to stress. s/vise versa/vice versa/ src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/23246/#comment82870> s/if/if it/ src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/23246/#comment82871> s/We then/Now/ src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/23246/#comment82872> s/Instead/NOTE: Instead/ src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/23246/#comment82873> s/makeRecursivelyShared/mountShared/ src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/23246/#comment82874> s/recursively slave/slave mount/ - Vinod Kone On July 2, 2014, 8:57 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23246/ > ----------------------------------------------------------- > > (Updated July 2, 2014, 8:57 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, and Vinod Kone. > > > Bugs: MESOS-1558 > https://issues.apache.org/jira/browse/MESOS-1558 > > > Repository: mesos-git > > > Description > ------- > > See summary. The idea is to use --make-rshared for /var/run/netns on host and > --make-rslave for /var/run/netns in each container. > > > Diffs > ----- > > src/slave/containerizer/isolators/network/port_mapping.cpp a326653 > > Diff: https://reviews.apache.org/r/23246/diff/ > > > Testing > ------- > > make check > sudo make check > > The regression tests is in another review by Chi Zhang: > https://reviews.apache.org/r/23221/ > > > Thanks, > > Jie Yu > >
