-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23246/#review47253
-----------------------------------------------------------

Ship it!



src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/23246/#comment82901>

    I don't follow why you need to bind mount the directory to itself? Can't 
you do this:
    
    [root@hostname tmp]# mkdir foo1
    [root@hostname tmp]# mkdir foo2
    [root@hostname tmp]# mount --bind foo1 foo2
    [root@hostname tmp]# mount --make-rshared foo1
    [root@hostname tmp]# mount --make-rslave foo2
    [root@hostname tmp]#
    
    Can you clarify what I'm missing...?


- Ian Downes


On July 2, 2014, 2:59 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23246/
> -----------------------------------------------------------
> 
> (Updated July 2, 2014, 2:59 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, and Vinod Kone.
> 
> 
> Bugs: MESOS-1558
>     https://issues.apache.org/jira/browse/MESOS-1558
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary. The idea is to use --make-rshared for /var/run/netns on host and 
> --make-rslave for /var/run/netns in each container.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/isolators/network/port_mapping.cpp a326653 
> 
> Diff: https://reviews.apache.org/r/23246/diff/
> 
> 
> Testing
> -------
> 
> make check
> sudo make check
> 
> The regression tests is in another review by Chi Zhang:
> https://reviews.apache.org/r/23221/
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to