> On July 13, 2014, 8:44 a.m., Adam B wrote: > > LGTM. Did you test with/without in interesting combinations?
Standard testing for it. I took special care around libev, as packagers will likely need to address the constraint that libev is a rebuild library. So make check will fail in glorious ways unless it has been rebuilt properly. > On July 13, 2014, 8:44 a.m., Adam B wrote: > > 3rdparty/libprocess/configure.ac, lines 81-85 > > <https://reviews.apache.org/r/23414/diff/1/?file=628545#file628545line81> > > > > tabbing? Same comment, it's all mixed up in the file. Let me know the route and I will update * . - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23414/#review47694 ----------------------------------------------------------- On July 11, 2014, 4:16 p.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23414/ > ----------------------------------------------------------- > > (Updated July 11, 2014, 4:16 p.m.) > > > Review request for mesos, Adam B and Benjamin Hindman. > > > Bugs: MESOS-1172 > https://issues.apache.org/jira/browse/MESOS-1172 > > > Repository: mesos-git > > > Description > ------- > > Enable mesos to build against the system installed version of libev. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am 429c956 > 3rdparty/libprocess/Makefile.am 87cf1ae > 3rdparty/libprocess/configure.ac 27c6ede > > Diff: https://reviews.apache.org/r/23414/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy St. Clair > >