> On July 15, 2014, 5:47 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/configure.ac, line 146 > > <https://reviews.apache.org/r/23414/diff/1/?file=628545#file628545line146> > > > > Sorry for jumping in late, but is there a way to check the > > "EV_CHILD_ENABLE" condition at configure time? I'm afraid users will easily > > miss this warning among all the lines that configure spews which will later > > cause hard to debug errors. > > Timothy St. Clair wrote: > 'make check' also fails in glorious fashion. > > Perhaps we should update the instructions on how to build > w/--disable-bundled? > > > > Vinod Kone wrote: > Documentation would definitely be nice. 'make check' failing due to > un-patched libev would be hard to diagnose for users imo. Is it possible to > write a tiny program in configure.ac to check this ala how we did for java > and python? Maybe TODO for now.
I'll add a couple of items to the parent ticket. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23414/#review47784 ----------------------------------------------------------- On July 11, 2014, 4:16 p.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23414/ > ----------------------------------------------------------- > > (Updated July 11, 2014, 4:16 p.m.) > > > Review request for mesos, Adam B and Benjamin Hindman. > > > Bugs: MESOS-1172 > https://issues.apache.org/jira/browse/MESOS-1172 > > > Repository: mesos-git > > > Description > ------- > > Enable mesos to build against the system installed version of libev. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am 429c956 > 3rdparty/libprocess/Makefile.am 87cf1ae > 3rdparty/libprocess/configure.ac 27c6ede > > Diff: https://reviews.apache.org/r/23414/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy St. Clair > >
