> On April 23, 2014, 1:06 a.m., Adam B wrote: > > src/master/master.cpp, lines 1062-1068 > > <https://reviews.apache.org/r/20507/diff/2/?file=563937#file563937line1062> > > > > Couldn't this also happen if a (misbehaving) framework completes/fails > > in any other way, then tries to re-register with the same id? Doesn't have > > to be a failover timeout.
Thats true. Thats why it says "could" :) I'm open to a better phrasing suggestion though. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20507/#review41103 ----------------------------------------------------------- On April 22, 2014, 12:20 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20507/ > ----------------------------------------------------------- > > (Updated April 22, 2014, 12:20 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-1219 > https://issues.apache.org/jira/browse/MESOS-1219 > > > Repository: mesos-git > > > Description > ------- > > This is only a partial fix for MESOS-1219. > > > Diffs > ----- > > src/master/master.cpp 0335b3416ee1c4d14a70e018ad9174b465035c5f > src/tests/fault_tolerance_tests.cpp > 4796149beb10a6c668762f5efecd86520b809c42 > > Diff: https://reviews.apache.org/r/20507/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
