----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22796/#review47989 -----------------------------------------------------------
Ship it! Just fix these minor issues, especially the Clock::advance(0), and then we can commit it! src/tests/master_tests.cpp <https://reviews.apache.org/r/22796/#comment84249> Clock::resume() after? src/tests/master_tests.cpp <https://reviews.apache.org/r/22796/#comment84247> End your comment with a period. (new lint rule?) src/tests/master_tests.cpp <https://reviews.apache.org/r/22796/#comment84244> s/Register/Registered/ src/tests/master_tests.cpp <https://reviews.apache.org/r/22796/#comment84245> If masterFlags.offer_timeout == 0, this won't be advancing the clock at all. How about doubling the default timeout instead? src/tests/master_tests.cpp <https://reviews.apache.org/r/22796/#comment84246> rescinded Also, end the comment with a period. src/tests/master_tests.cpp <https://reviews.apache.org/r/22796/#comment84248> Only single-space. (new lint rule?) - Adam B On July 10, 2014, 10:47 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22796/ > ----------------------------------------------------------- > > (Updated July 10, 2014, 10:47 a.m.) > > > Review request for mesos, Adam B and Niklas Nielsen. > > > Bugs: MESOS-186 > https://issues.apache.org/jira/browse/MESOS-186 > > > Repository: mesos-git > > > Description > ------- > > Based on Kapil's patch (https://reviews.apache.org/r/22066/), adding timeout > for each offer from master to remove the offer when it's no longer used. > > > Diffs > ----- > > src/master/flags.hpp 32704ce > src/master/master.hpp 8641f2d > src/master/master.cpp 86b147f > src/tests/master_tests.cpp 5a1cf7f > > Diff: https://reviews.apache.org/r/22796/diff/ > > > Testing > ------- > > Added three more unit tests from Kapil's patch: Testing offer not rescinded > after task launched, offer not rescinded when framework/slave unregistered. > The test exposed a race condition that can lead to a segfault if two remove > offers are called on the same offer. > > make check. > > > Thanks, > > Timothy Chen > >
