> On July 24, 2014, 6:23 p.m., Ben Mahler wrote: > > src/tests/master_tests.cpp, lines 2055-2115 > > <https://reviews.apache.org/r/22796/diff/7/?file=634637#file634637line2055> > > > > I'm a bit puzzled by this test, I don't think we need this test since > > the framework cannot receive _any_ events after a framework unregistration, > > which seems orthogonal to the timeout you've introduced.
Makes sense, I'll remove it then. > On July 24, 2014, 6:23 p.m., Ben Mahler wrote: > > src/master/flags.hpp, lines 291-293 > > <https://reviews.apache.org/r/22796/diff/7/?file=634634#file634634line291> > > > > How about: > > > > "Duration of time before an offer is rescinded from a framework. This > > can help fairness when running frameworks that hold on to offers, or > > frameworks that accidentally drop offers. To disable the timeout, set this > > to '0secs'". > > > > Will '0' work for this, since it's a duration? Duration parse doesn't take zero though, has to specify a unit. Can add a special case for zero in another patch. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22796/#review48665 ----------------------------------------------------------- On July 24, 2014, 3 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22796/ > ----------------------------------------------------------- > > (Updated July 24, 2014, 3 a.m.) > > > Review request for mesos, Adam B, Ben Mahler, and Niklas Nielsen. > > > Bugs: MESOS-186 > https://issues.apache.org/jira/browse/MESOS-186 > > > Repository: mesos-git > > > Description > ------- > > Based on Kapil's patch (https://reviews.apache.org/r/22066/), adding timeout > for each offer from master to remove the offer when it's no longer used. > > > Diffs > ----- > > src/master/flags.hpp 32704ce > src/master/master.hpp fa46a67 > src/master/master.cpp fb2fd5a > src/tests/master_tests.cpp 5a1cf7f > > Diff: https://reviews.apache.org/r/22796/diff/ > > > Testing > ------- > > Added three more unit tests from Kapil's patch: Testing offer not rescinded > after task launched, offer not rescinded when framework/slave unregistered. > The test exposed a race condition that can lead to a segfault if two remove > offers are called on the same offer. > > make check. > > > Thanks, > > Timothy Chen > >
