> On July 17, 2014, 9:18 p.m., Vinod Kone wrote: > > configure.ac, line 315 > > <https://reviews.apache.org/r/23086/diff/1/?file=618608#file618608line315> > > > > would PKG_CHECK_MODULES work if protobuf is installed in a non-standard > > location that user specified with --with-protobuf=<dir>?
Added the check above on prefix. > On July 17, 2014, 9:18 p.m., Vinod Kone wrote: > > src/examples/java/test-exception-framework.in, line 18 > > <https://reviews.apache.org/r/23086/diff/1/?file=618611#file618611line18> > > > > What happens when the user gives > > --with-protobuf=/path/to/non-standard/location? > > > > is the jar still expected in /usr/share/java? > > > > is it possible to plumb through the user provided protobuf path to > > these scripts? that seems better than silently trying to pick the jar from > > a standard location? Overloaded to use AC_SUBST > On July 17, 2014, 9:18 p.m., Vinod Kone wrote: > > src/examples/python/test-framework.in, line 31 > > <https://reviews.apache.org/r/23086/diff/1/?file=618618#file618618line31> > > > > ditto. saying "failed" and proceeding seems weird. is the egg expected > > to be on the python path? if yes, we should at least tell the users so? This actually doesn't matter so much as they user can adjust their PYTHONPATH. For 99% of cases where folks will use the system installation of protobuf, this is a non-issue. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23086/#review48049 ----------------------------------------------------------- On June 26, 2014, 7:31 p.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23086/ > ----------------------------------------------------------- > > (Updated June 26, 2014, 7:31 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1174 > https://issues.apache.org/jira/browse/MESOS-1174 > > > Repository: mesos-git > > > Description > ------- > > Enable mesos to build against system installed version of protobuf. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am 429c956 > 3rdparty/libprocess/configure.ac 27c6ede > configure.ac 41f3c2b > mpi/mpiexec-mesos.in da0733f > src/Makefile.am 3c8b91a > src/examples/java/test-exception-framework.in 065f3c0 > src/examples/java/test-executor.in 35559d2 > src/examples/java/test-framework.in 9af48f9 > src/examples/java/test-log.in 8afed0d > src/examples/java/test-multiple-executors-framework.in 235eb23 > src/examples/python/test-containerizer.in 569519b > src/examples/python/test-executor.in 7e8875f > src/examples/python/test-framework.in c4683b9 > src/python/setup.py.in b996dfe > > Diff: https://reviews.apache.org/r/23086/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy St. Clair > >
