> On Aug. 5, 2014, 1:18 a.m., Vinod Kone wrote: > > 3rdparty/libprocess/configure.ac, line 303 > > <https://reviews.apache.org/r/23086/diff/2/?file=639448#file639448line303> > > > > instead of hardcoding the version, is there a way to get this from > > 3rdparty versions.am?
So autoconf feeds forward into automake. I don't know of a clean way to handle, unless it went through some common m4. I'm hoping *this is temporary, and in next version we can remove this entirely and just check for protobuf, as it exists on nearly all platforms. > On Aug. 5, 2014, 1:18 a.m., Vinod Kone wrote: > > configure.ac, line 347 > > <https://reviews.apache.org/r/23086/diff/2/?file=639449#file639449line347> > > > > instead of hardcoding the version, is there a way to get this from > > 3rdparty versions.am? same as previous comment. > On Aug. 5, 2014, 1:18 a.m., Vinod Kone wrote: > > src/Makefile.am, line 52 > > <https://reviews.apache.org/r/23086/diff/2/?file=639451#file639451line52> > > > > would this work if 'protoc' is installed in a prefix location? Added a hard check in configure, it should be in the path. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23086/#review49532 ----------------------------------------------------------- On July 22, 2014, 6:14 p.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23086/ > ----------------------------------------------------------- > > (Updated July 22, 2014, 6:14 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-1174 > https://issues.apache.org/jira/browse/MESOS-1174 > > > Repository: mesos-git > > > Description > ------- > > Enable mesos to build against system installed version of protobuf. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am 705d19c > 3rdparty/libprocess/configure.ac 3a38b04 > configure.ac e747208 > mpi/mpiexec-mesos.in da0733f > src/Makefile.am c216e2f > src/examples/java/test-exception-framework.in 065f3c0 > src/examples/java/test-executor.in 35559d2 > src/examples/java/test-framework.in 9af48f9 > src/examples/java/test-log.in 8afed0d > src/examples/java/test-multiple-executors-framework.in 235eb23 > src/examples/python/test-containerizer.in 569519b > src/examples/python/test-executor.in 7e8875f > src/examples/python/test-framework.in c4683b9 > src/python/setup.py.in b996dfe > > Diff: https://reviews.apache.org/r/23086/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy St. Clair > >
