----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21750/#review48908 -----------------------------------------------------------
src/master/master.cpp <https://reviews.apache.org/r/21750/#comment85686> When offers are removed (which I think is the only path of how Offer can no longer exist), the offer object is also being deleted as well. Therefore, I think if we keep using OfferID& that is referencing the offerId from the offer object it is a undefined behavior. - Timothy Chen On May 29, 2014, 12:17 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21750/ > ----------------------------------------------------------- > > (Updated May 29, 2014, 12:17 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Niklas Nielsen. > > > Bugs: MESOS-1400 > https://issues.apache.org/jira/browse/MESOS-1400 > > > Repository: mesos-git > > > Description > ------- > > Fixed Master::launchTasks() to inform allocator of unused resources when any > of the offers are invalid. > > > Diffs > ----- > > src/master/master.cpp efb4de1216df3fccf3706a5c615960ec00434440 > src/tests/master_tests.cpp b0ff6277120636fe9045b12443e5e2dd29a3df1b > > Diff: https://reviews.apache.org/r/21750/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
