> On July 28, 2014, 9:23 p.m., Timothy Chen wrote: > > src/master/master.cpp, line 1679 > > <https://reviews.apache.org/r/21750/diff/3/?file=598185#file598185line1679> > > > > When offers are removed (which I think is the only path of how Offer > > can no longer exist), the offer object is also being deleted as well. > > Therefore, I think if we keep using OfferID& that is referencing the > > offerId from the offer object it is a undefined behavior.
Is there a bug here? The offerIds that are getting passed into the offer visitors are not references inside the 'Offer' heap object, they are parameters to launchTasks() coming from the parsed 'LaunchTasksMessage' protobuf. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21750/#review48908 ----------------------------------------------------------- On May 29, 2014, 12:17 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21750/ > ----------------------------------------------------------- > > (Updated May 29, 2014, 12:17 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Niklas Nielsen. > > > Bugs: MESOS-1400 > https://issues.apache.org/jira/browse/MESOS-1400 > > > Repository: mesos-git > > > Description > ------- > > Fixed Master::launchTasks() to inform allocator of unused resources when any > of the offers are invalid. > > > Diffs > ----- > > src/master/master.cpp efb4de1216df3fccf3706a5c615960ec00434440 > src/tests/master_tests.cpp b0ff6277120636fe9045b12443e5e2dd29a3df1b > > Diff: https://reviews.apache.org/r/21750/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
