----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23997/#review48918 -----------------------------------------------------------
Thanks for sending this Ken! There is one small bug that would be nice to fix before getting this committed. We also might want to leave a TODO here to enhance URL::parse to handle "file://" URLs as well to avoid all the redundant code: https://github.com/apache/mesos/blob/0.19.1/src/master/detector.cpp#L121 https://github.com/apache/mesos/blob/0.19.1/src/master/contender.cpp#L87 src/master/main.cpp <https://reviews.apache.org/r/23997/#comment85701> What if this url is an error? The code below assumes it is not by calling url.get(), which will crash the program if this url object is an error. Also please use a 2 space indent as per the rest of this file :) - Ben Mahler On July 28, 2014, 7:46 p.m., Ken Sipe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23997/ > ----------------------------------------------------------- > > (Updated July 28, 2014, 7:46 p.m.) > > > Review request for mesos, Adam B and Ben Mahler. > > > Bugs: MESOS-1635 > https://issues.apache.org/jira/browse/MESOS-1635 > > > Repository: mesos-git > > > Description > ------- > > Fixes MESOS-1635 "zk flag fails when specifying a file and the replicated > logs" > > replaced the current TODO with code :) The code is consistent with similar > types of checks elsewhere in code. > > > Diffs > ----- > > src/master/main.cpp 4d39c355eae948ede492d84de2e58a26756b781a > > Diff: https://reviews.apache.org/r/23997/diff/ > > > Testing > ------- > > The code change is simple and no unit test is provided. It compiles, passes > style check and is functional via manual check. > > > Thanks, > > Ken Sipe > >
