> On July 29, 2014, 3:06 p.m., Jiang Yan Xu wrote: > > src/master/contender.cpp, line 79 > > <https://reviews.apache.org/r/23997/diff/3/?file=644484#file644484line79> > > > > Master detector and contender already support --zk=file://, in the > > "else if (strings::startsWith(zk, "file://"))" branch below. > > > > Looks like the same logic exists in a couple of places it may be > > reasonable to pull it into "Try<URL> URL::parse(const std::string& url)" > > directly. > > Ben Mahler wrote: > Good point, that's what this TODO is for but I will clear up the > confusion and have a single TODO inside url.hpp.
Oh I see. Cool, thanks :) - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23997/#review49033 ----------------------------------------------------------- On July 29, 2014, 7:33 a.m., Ken Sipe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23997/ > ----------------------------------------------------------- > > (Updated July 29, 2014, 7:33 a.m.) > > > Review request for mesos, Adam B and Ben Mahler. > > > Bugs: MESOS-1635 > https://issues.apache.org/jira/browse/MESOS-1635 > > > Repository: mesos-git > > > Description > ------- > > Fixes MESOS-1635 "zk flag fails when specifying a file and the replicated > logs" > > replaced the current TODO with code :) The code is consistent with similar > types of checks elsewhere in code. > > > Diffs > ----- > > src/master/contender.cpp c1bf82b621d6b46afe001acafe9ee53336726406 > src/master/detector.cpp a34cc211941972e2d64802d5c7ed3f5026229744 > src/master/main.cpp 4d39c355eae948ede492d84de2e58a26756b781a > > Diff: https://reviews.apache.org/r/23997/diff/ > > > Testing > ------- > > The code change is simple and no unit test is provided. It compiles, passes > style check and is functional via manual check. > > > Thanks, > > Ken Sipe > >
