----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23771/#review49117 -----------------------------------------------------------
src/docker/docker.hpp <https://reviews.apache.org/r/23771/#comment85959> Please move the right parenthesis up right next to '_pid': Container( const std::string& _id, const std::string& _name, const Option<pid_t>& _pid) : id(_id), name(_name), pid(_pid) {} src/docker/docker.cpp <https://reviews.apache.org/r/23771/#comment86069> This is a continuation, renamed it to '_failure'. Also, make them 'static' since it only used in this cpp file. Same for the following functions as well. src/docker/docker.cpp <https://reviews.apache.org/r/23771/#comment86068> s/failedMessage/failure/ src/docker/docker.cpp <https://reviews.apache.org/r/23771/#comment86070> What if errFd is closed because the corresponding Subprocess goes out of scope? You may want to hold a reference to the Subprocess by passing it in? src/docker/docker.cpp <https://reviews.apache.org/r/23771/#comment86071> We typically do not use else in this case: if (...) { } io::read(...)... src/docker/docker.cpp <https://reviews.apache.org/r/23771/#comment86073> You probably want to pass Subprocess in here. src/docker/docker.cpp <https://reviews.apache.org/r/23771/#comment86072> I think making 'success' a static function and get rid of the docker::internal namespace is better. - Jie Yu On July 30, 2014, 8:42 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23771/ > ----------------------------------------------------------- > > (Updated July 30, 2014, 8:42 p.m.) > > > Review request for mesos, Benjamin Hindman, Ian Downes, and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > Docker implementation. > This is all the docker code Ben, I and Yifan worked on excluding the > composing containerizer patches. > > > Diffs > ----- > > src/Makefile.am 45afcd1 > src/common/status_utils.hpp 1980551 > src/docker/docker.hpp PRE-CREATION > src/docker/docker.cpp PRE-CREATION > src/examples/docker_no_executor_framework.cpp PRE-CREATION > src/health-check/main.cpp 707810a > src/launcher/executor.cpp 9c80848 > src/linux/cgroups.hpp decad9d > src/linux/cgroups.cpp 6a73dd7 > src/master/master.cpp 251b699 > src/slave/containerizer/containerizer.cpp 1b71f33 > src/slave/containerizer/docker.hpp PRE-CREATION > src/slave/containerizer/docker.cpp PRE-CREATION > src/slave/containerizer/external_containerizer.cpp 3f28d85 > src/slave/containerizer/isolators/cgroups/cpushare.hpp 780037b > src/slave/containerizer/isolators/cgroups/cpushare.cpp 3265a80 > src/slave/containerizer/isolators/cgroups/mem.hpp 8c476c7 > src/slave/containerizer/isolators/cgroups/mem.cpp e8d1e35 > src/slave/containerizer/isolators/posix.hpp 17bbd10 > src/slave/flags.hpp 1fe7b7d > src/slave/slave.cpp f42ab60 > src/tests/cgroups_tests.cpp 01cf498 > src/tests/docker_containerizer_tests.cpp PRE-CREATION > src/tests/docker_tests.cpp PRE-CREATION > src/tests/environment.cpp 434b3f7 > src/tests/flags.hpp a003e7f > src/tests/script.cpp 15a6542 > src/usage/usage.hpp 5a76746 > src/usage/usage.cpp 29014d1 > > Diff: https://reviews.apache.org/r/23771/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
