----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23771/#review49320 -----------------------------------------------------------
Ship it! LGTM! Please rebase to the master and I'll get it committed tomorrow! Thanks Tim! src/docker/docker.hpp <https://reviews.apache.org/r/23771/#comment86289> I guess we have some mis-communication last time. I want these function to be static to the cpp file (not static to this class) so that you don't need to declare them in the header file. src/docker/docker.cpp <https://reviews.apache.org/r/23771/#comment86290> Add a comment about this helper: // Asynchronously read stderr from subprocess. src/docker/docker.cpp <https://reviews.apache.org/r/23771/#comment86293> Add a comment about this helper. Say 'Return a failure if error occurs'. Also, checkError seems to be a more appropriate name src/docker/docker.cpp <https://reviews.apache.org/r/23771/#comment86296> Add a TODO here saying: // TODO: Consider returning stdout as well. src/docker/docker.cpp <https://reviews.apache.org/r/23771/#comment86297> The semantics here is that you'll return the result of 'docker.rm' if 'kill' failed and 'remove=true', right? If yes, please document this somewhere. - Jie Yu On Aug. 1, 2014, 12:46 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23771/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2014, 12:46 a.m.) > > > Review request for mesos, Benjamin Hindman, Ian Downes, and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > Docker implementation. > This is all the docker code Ben, I and Yifan worked on excluding the > composing containerizer patches. > > > Diffs > ----- > > src/Makefile.am 45afcd1 > src/common/status_utils.hpp c51a8c6 > src/docker/docker.hpp PRE-CREATION > src/docker/docker.cpp PRE-CREATION > src/examples/docker_no_executor_framework.cpp PRE-CREATION > src/health-check/main.cpp 10d57a0 > src/launcher/executor.cpp 948673e > src/linux/cgroups.hpp decad9d > src/linux/cgroups.cpp af6be22 > src/master/master.cpp 77f2536 > src/slave/containerizer/containerizer.cpp 1b71f33 > src/slave/containerizer/docker.hpp PRE-CREATION > src/slave/containerizer/docker.cpp PRE-CREATION > src/slave/containerizer/external_containerizer.cpp 3f28d85 > src/slave/containerizer/isolators/cgroups/cpushare.hpp 780037b > src/slave/containerizer/isolators/cgroups/cpushare.cpp 3265a80 > src/slave/containerizer/isolators/cgroups/mem.hpp 8c476c7 > src/slave/containerizer/isolators/cgroups/mem.cpp e8d1e35 > src/slave/containerizer/isolators/posix.hpp 17bbd10 > src/slave/flags.hpp 1fe7b7d > src/slave/slave.cpp f42ab60 > src/tests/cgroups_tests.cpp 01cf498 > src/tests/docker_containerizer_tests.cpp PRE-CREATION > src/tests/docker_tests.cpp PRE-CREATION > src/tests/environment.cpp 551698f > src/tests/flags.hpp a003e7f > src/tests/script.cpp 0d29c6d > src/usage/usage.hpp 5a76746 > src/usage/usage.cpp 29014d1 > > Diff: https://reviews.apache.org/r/23771/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
