----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23710/#review49333 -----------------------------------------------------------
support/cpplint.patch <https://reviews.apache.org/r/23710/#comment86330> Please also add a "Modified by" line(s) explaining the new rule you added. support/cpplint.py <https://reviews.apache.org/r/23710/#comment86333> What is the startswith("--") for? Command-line parameters? It's not mentioned in your comment above. support/cpplint.py <https://reviews.apache.org/r/23710/#comment86329> What's with the "// dummy" exemption? support/cpplint.py <https://reviews.apache.org/r/23710/#comment86331> Do you really think this is severity '5'? I'd probably drop it down to 3 at most. support/cpplint.py <https://reviews.apache.org/r/23710/#comment86332> "Could not allow..." reads funny. How about just "Comment should end in punctuation.", or "Comment should end in non-alphabetical character." if you want to be more exact? support/cpplint.py <https://reviews.apache.org/r/23710/#comment86328> Reads like broken English, and is too specific about the 'Period'. How about "CheckForEndingPunctuationInComments" or "CheckForCommentsEndingInPunctuation"? support/mesos-style.py <https://reviews.apache.org/r/23710/#comment86327> You could probably change this to "readability/ending_punctuation" to keep it down to two words. The fact that it applies to comments is secondary; that's just where you're applying the ending_punctuation rule. - Adam B On July 19, 2014, 1:53 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23710/ > ----------------------------------------------------------- > > (Updated July 19, 2014, 1:53 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Add line comments end punctuation style rule > > > Diffs > ----- > > support/cpplint.patch 4f1ec668822b3ea3d8bfb12d7d41408ccaa42271 > support/cpplint.py 90aa4ba648ce83f84ec62d96e26eba5e7f11f30c > support/mesos-style.py fd12be9ad1647e658bca45f181f9aa9da1a15084 > > Diff: https://reviews.apache.org/r/23710/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
