I see, it collapsed multi line comments into a single line so line numbers are off..
I'll figure something out soon. Tim Sent from my iPhone > On Aug 26, 2014, at 7:30 PM, "Adam B" <a...@mesosphere.io> wrote: > > > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23710/ > > On August 25th, 2014, 1:01 a.m. PDT, Adam B wrote: > > support/cpplint.py (Diff revision 2) > 1550 > error(filename, i, 'readability/ending_punctuation', 3, > 1551 > 'Comment should end in non-alphabetical character. \n Line: ' > + > 1552 > previous_line + '\n') > s/i/i-1/? > On August 25th, 2014, 4:03 p.m. PDT, Timothy Chen wrote: > > ah, I think it should be i+1? since it's 0 based index. > On August 25th, 2014, 4:51 p.m. PDT, Timothy Chen wrote: > > Actually it should be i because of the padding done. > On August 25th, 2014, 11:54 p.m. PDT, Adam B wrote: > > What testing was done on this code? 'make check' hardly seems relevant. > > Did you verify that these style errors print the correct line number? > I just tested this with a malformed comment on line 1 and line 4079 (last) of > a file. Here's what it prints: > > src/slave/slave.cpp:19: Comment should end in non-alphabetical character. > > Line: // foo bar > > src/slave/slave.cpp:4080: Comment should end in non-alphabetical character. > > Line: // foo bar > > Looks like the line number calculation is wrong. :( > > - Adam > > > On August 25th, 2014, 5:12 p.m. PDT, Timothy Chen wrote: > > Review request for mesos, Adam B, Benjamin Hindman, and Niklas Nielsen. > By Timothy Chen. > Updated Aug. 25, 2014, 5:12 p.m. > > Repository: mesos-git > Description > > Review: https://reviews.apache.org/r/23710 > Testing > > make check > Diffs > > support/cpplint.patch (1dd69a03044c0c17ca4ee555c6c9d27ea043d4f0) > support/cpplint.py (bfd3390002a680b07aa3fcf785279ad19625294b) > support/mesos-style.py (d24cb11adc06bc0ebaaa206301616c8b597f09e8) > View Diff
