----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24356/#review49898 -----------------------------------------------------------
Ship it! See my comment in the test below, otherwise this looks good to go. src/tests/allocator_tests.cpp <https://reviews.apache.org/r/24356/#comment87310> Can we still not do Some("role1,role2")? I'm guessing you need Option<string> because the compiler can't go from const char* to Option<string> right? src/tests/allocator_tests.cpp <https://reviews.apache.org/r/24356/#comment87311> This makes me feel like you're assuming there is going to be a time delay between when the resources are recovered and the next allocation, otherwise, especially since you set the refuse seconds to 0, these resources should be reallocated right away. I think you want to have the other framework already registered before the first framework declines so that you're guaranteed that there isn't some weird timing event that makes this test be flaky. Or if I'm missing something please leave a big comment explaining why you don't need to do it that way, and any assumptions you're making. - Benjamin Hindman On Aug. 6, 2014, 10:56 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24356/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2014, 10:56 p.m.) > > > Review request for mesos, Adam B and Benjamin Hindman. > > > Bugs: MESOS-1119 > https://issues.apache.org/jira/browse/MESOS-1119 > > > Repository: mesos-git > > > Description > ------- > > The allocator now updates the DRF algorithm after every allocation of a > slave's resources. This will make the allocation more granular and fair. > > > Diffs > ----- > > src/master/hierarchical_allocator_process.hpp > c7e689e882e88ef5adb31e72909ef85d8a8c0067 > src/tests/allocator_tests.cpp f0226cb3fa4b54f917c0a0f59b986e9115352507 > > Diff: https://reviews.apache.org/r/24356/diff/ > > > Testing > ------- > > make check > > make check GTEST_FILTER="*PerSlaveAllocation*" GTEST_REPEAT=1000 > GTEST_BREAK_ON_FAILURE=1 GTEST_VERBOSE=1 MESOS_VERBOSE=1 GLOG_v=1 > > > Thanks, > > Vinod Kone > >
