> On Aug. 7, 2014, 3:23 p.m., Benjamin Hindman wrote: > > src/tests/allocator_tests.cpp, lines 405-407 > > <https://reviews.apache.org/r/24356/diff/3/?file=654288#file654288line405> > > > > This makes me feel like you're assuming there is going to be a time > > delay between when the resources are recovered and the next allocation, > > otherwise, especially since you set the refuse seconds to 0, these > > resources should be reallocated right away. I think you want to have the > > other framework already registered before the first framework declines so > > that you're guaranteed that there isn't some weird timing event that makes > > this test be flaky. Or if I'm missing something please leave a big comment > > explaining why you don't need to do it that way, and any assumptions you're > > making.
Added a comment. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24356/#review49898 ----------------------------------------------------------- On Aug. 7, 2014, 11:02 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24356/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2014, 11:02 p.m.) > > > Review request for mesos, Adam B and Benjamin Hindman. > > > Bugs: MESOS-1119 > https://issues.apache.org/jira/browse/MESOS-1119 > > > Repository: mesos-git > > > Description > ------- > > The allocator now updates the DRF algorithm after every allocation of a > slave's resources. This will make the allocation more granular and fair. > > > Diffs > ----- > > src/master/hierarchical_allocator_process.hpp > d81082f7fa2a4ffc13f18c232abb8ad2814bebc1 > src/tests/allocator_tests.cpp f0226cb3fa4b54f917c0a0f59b986e9115352507 > > Diff: https://reviews.apache.org/r/24356/diff/ > > > Testing > ------- > > make check > > make check GTEST_FILTER="*PerSlaveAllocation*" GTEST_REPEAT=1000 > GTEST_BREAK_ON_FAILURE=1 GTEST_VERBOSE=1 MESOS_VERBOSE=1 GLOG_v=1 > > > Thanks, > > Vinod Kone > >
