> On Aug. 11, 2014, 4:34 a.m., Benjamin Hindman wrote: > > src/slave/containerizer/docker.cpp, line 720 > > <https://reviews.apache.org/r/24475/diff/2/?file=657110#file657110line720> > > > > Just re-iterating what I was commented on earlier, if you put the > > container in 'promises' then you could do the following here (and below in > > the other 'launch' too): > > > > fetch(...) > > .onFailed([] () { promises.erase(containerId); }) > > .then(... _launch ...); > > > > Maybe I'm missing something else? If so, need more documentation please!
We can't use C++11 lambdas yet right? Thought we want to be backward compatible for now. But yes I was calling destroy just to clean up promises and not to create another callback method. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24475/#review50135 ----------------------------------------------------------- On Aug. 10, 2014, 7:39 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24475/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2014, 7:39 a.m.) > > > Review request for mesos, Benjamin Hindman, Ian Downes, and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > Added new DockerInfo for future docker options, and allow command uris to be > fetched and mapped into docker before launching docker container. > > > Diffs > ----- > > include/mesos/mesos.proto cc9f20e > src/docker/docker.hpp 98b2d60 > src/docker/docker.cpp 1cba381 > src/slave/containerizer/containerizer.hpp 02754cd > src/slave/containerizer/containerizer.cpp c91ba38 > src/slave/containerizer/docker.cpp 904cdd3 > src/slave/containerizer/mesos/containerizer.cpp 694c9d1 > src/slave/slave.cpp 787bd05 > src/tests/docker_containerizer_tests.cpp a559836 > src/tests/docker_tests.cpp 4ef1df4 > > Diff: https://reviews.apache.org/r/24475/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
