> On Aug. 11, 2014, 5:08 a.m., Timothy Chen wrote: > > include/mesos/mesos.proto, line 844 > > <https://reviews.apache.org/r/24475/diff/2/?file=657105#file657105line844> > > > > I'm not sure what the practice is, but thought it's easier to reserve 1 > > - 100 for common properties and 100 - max for union types. I can just > > number them serially but thought it can get confusing since we don't want > > to order the fields by number but by sections. What you think? > > Benjamin Hindman wrote: > Folks usually just look for the highest number and add 1. If they see 100 > they're not going to know that N - 100 are actually "available" unless that's > documented since it's possible that a field was added, deprecated, and then > removed. This is also why some people keep all deprecated fields but just > move them to the bottom, so that field numbers are guaranteed not to be > reused!
Sounds good, I'll change this. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24475/#review50149 ----------------------------------------------------------- On Aug. 10, 2014, 7:39 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24475/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2014, 7:39 a.m.) > > > Review request for mesos, Benjamin Hindman, Ian Downes, and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > Added new DockerInfo for future docker options, and allow command uris to be > fetched and mapped into docker before launching docker container. > > > Diffs > ----- > > include/mesos/mesos.proto cc9f20e > src/docker/docker.hpp 98b2d60 > src/docker/docker.cpp 1cba381 > src/slave/containerizer/containerizer.hpp 02754cd > src/slave/containerizer/containerizer.cpp c91ba38 > src/slave/containerizer/docker.cpp 904cdd3 > src/slave/containerizer/mesos/containerizer.cpp 694c9d1 > src/slave/slave.cpp 787bd05 > src/tests/docker_containerizer_tests.cpp a559836 > src/tests/docker_tests.cpp 4ef1df4 > > Diff: https://reviews.apache.org/r/24475/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
