----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24475/#review50404 -----------------------------------------------------------
Ship it! src/slave/containerizer/docker.cpp <https://reviews.apache.org/r/24475/#comment88179> What about taking a lambda::_1 here to just get the failure message? Then you can pass just failure messages to _fetchFailed from _fetch without having to pass the whole future. src/slave/containerizer/docker.cpp <https://reviews.apache.org/r/24475/#comment88178> A CHECK_FAILED(status) would be nice here, but I don't think it's necessary if this function just takes a string. - Benjamin Hindman On Aug. 13, 2014, 2:59 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24475/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2014, 2:59 a.m.) > > > Review request for mesos, Benjamin Hindman, Ian Downes, and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > Added new DockerInfo for future docker options, and allow command uris to be > fetched and mapped into docker before launching docker container. > > > Diffs > ----- > > include/mesos/mesos.proto cc9f20e > src/docker/docker.hpp 98b2d60 > src/docker/docker.cpp 1cba381 > src/slave/containerizer/containerizer.hpp 02754cd > src/slave/containerizer/containerizer.cpp c91ba38 > src/slave/containerizer/docker.cpp 904cdd3 > src/slave/containerizer/mesos/containerizer.cpp 694c9d1 > src/slave/flags.hpp 841de23 > src/slave/slave.cpp 787bd05 > src/tests/docker_containerizer_tests.cpp a559836 > src/tests/docker_tests.cpp 4ef1df4 > > Diff: https://reviews.apache.org/r/24475/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
