----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24719/#review50668 -----------------------------------------------------------
Ship it! docs/network-monitoring.md <https://reviews.apache.org/r/24719/#comment88519> s/Our/The current/ ? can you expand on "will not notice any difference"? you mean no difference w.r.t getting a private bridge, NAT or anything like that right? docs/network-monitoring.md <https://reviews.apache.org/r/24719/#comment88520> s/Prerequisite/Prerequisites/ docs/network-monitoring.md <https://reviews.apache.org/r/24719/#comment88521> s/our code/Mesos/ docs/network-monitoring.md <https://reviews.apache.org/r/24719/#comment88522> Can you update the "getting started doc" too w.r.t these pre-reqs for network monitoring? docs/network-monitoring.md <https://reviews.apache.org/r/24719/#comment88523> is there an authoritative doc that we can link to for more info on "network namespaces"? docs/network-monitoring.md <https://reviews.apache.org/r/24719/#comment88524> s/port/ports/ ? docs/network-monitoring.md <https://reviews.apache.org/r/24719/#comment88526> s/previously/ pre 0.20.0/ or maybe s/previously/without network monitoring/ s/non of the/none of the/ s/host process is/host processes are/ docs/network-monitoring.md <https://reviews.apache.org/r/24719/#comment88527> s/squeeze/squeeze and reboot/ docs/network-monitoring.md <https://reviews.apache.org/r/24719/#comment88528> Also, note that they need to add "network/portmapping" to --isolation flag. s/resource/resource (via '--resources' flag)/ s/wanna/want to/ :) docs/network-monitoring.md <https://reviews.apache.org/r/24719/#comment88529> s/this is/these are/ docs/network-monitoring.md <https://reviews.apache.org/r/24719/#comment88530> give a random executor_id, executor_name and source instead of "aurora/thermos" :) - Vinod Kone On Aug. 15, 2014, 12:13 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24719/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2014, 12:13 a.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang. > > > Repository: mesos-git > > > Description > ------- > > See summary > > > Diffs > ----- > > docs/network-monitoring.md PRE-CREATION > > Diff: https://reviews.apache.org/r/24719/diff/ > > > Testing > ------- > > checked the markdown syntax > > > Thanks, > > Jie Yu > >
