----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24719/#review50686 -----------------------------------------------------------
Ship it! all minor stuff. docs/network-monitoring.md <https://reviews.apache.org/r/24719/#comment88553> [czhang@tw-172-25-24-214 linux]$ git describe 6a662719c9868b3d6c7d26b3a085f0cd3cc15e64 v3.15-rc1-55-g6a66271 [czhang@tw-172-25-24-214 linux]$ git describe 0d5edc68739f1c1e0519acbea1d3f0c1882a15d7 v3.15-rc1-56-g0d5edc6 [czhang@tw-172-25-24-214 linux]$ git describe e374c618b1465f0292047a9f4c244bd71ab5f1f0 v3.15-rc1-512-ge374c61 [czhang@tw-172-25-24-214 linux]$ git describe 7a9bc9b81a5bc6e44ebc80ef781332e4385083f2 <-- can probably skip. v3.5-rc4-1092-g7a9bc9b [czhang@tw-172-25-24-214 linux]$ git describe 25f929fbff0d1bcebf2e92656d33025cd330cbf8 v3.14-rc2-257-g25f929f for the other 4, maybe rephrase to be more explict on 'a minimum 3.6 kernel + those patches _backported_'? docs/network-monitoring.md <https://reviews.apache.org/r/24719/#comment88558> for this whole dependency section, maybe just say something like 'network monitoring depends on libnl3 (url) >= 3.2.25. iproute2 (url) >= 2.6.39 is advised for debugging support ('ip netns' subcommands). docs/network-monitoring.md <https://reviews.apache.org/r/24719/#comment88549> iproute2 v2.6.39-8 starts to support netns docs/network-monitoring.md <https://reviews.apache.org/r/24719/#comment88554> s/world/network/ docs/network-monitoring.md <https://reviews.apache.org/r/24719/#comment88562> s/executor/executors/ docs/network-monitoring.md <https://reviews.apache.org/r/24719/#comment88561> add a shell-style comment at the end of the line to explain the effect? 'this reduces ephemeral ports available to host to only 57345-61000'? - Chi Zhang On Aug. 15, 2014, 12:13 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24719/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2014, 12:13 a.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang. > > > Repository: mesos-git > > > Description > ------- > > See summary > > > Diffs > ----- > > docs/network-monitoring.md PRE-CREATION > > Diff: https://reviews.apache.org/r/24719/diff/ > > > Testing > ------- > > checked the markdown syntax > > > Thanks, > > Jie Yu > >
