> On Aug. 19, 2014, 10:21 p.m., Ben Mahler wrote: > > src/tests/master_tests.cpp, lines 2134-2136 > > <https://reviews.apache.org/r/22066/diff/4/?file=662801#file662801line2134> > > > > This comment is no longer relevant, and we can remove the Clock::resume
Unfortunately you have to reply on the main review page for ReviewBoard to keep the thread of conversation intact, maybe they've fixed that in this new version :) Can you share how it fails when the Clock::resume it provided? So long as we pause/advance the clock *after* the offer timeout has been created, the timeout should fire once the clock is advanced and remains paused. Since we call 'delay' before sending the offers to the framework, and we have an AWAIT_READY(resourceOffers) before we pause the clock, resuming the clock should be unnecessary since we've paused it *after* the delay timer has been created. I must be missing something :) - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22066/#review51039 ----------------------------------------------------------- On Aug. 20, 2014, 1:54 a.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22066/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2014, 1:54 a.m.) > > > Review request for mesos, Adam B, Ben Mahler, Niklas Nielsen, and Timothy > Chen. > > > Bugs: mesos-186 > https://issues.apache.org/jira/browse/mesos-186 > > > Repository: mesos-git > > > Description > ------- > > A timer is associated with each newly created offer. > The offer is rescinded on timeout. > The timer is disarmed on a launchTask or decline. > > This is continuation of Tim's patch: https://reviews.apache.org/r/22796/. > Revision two represents the latest patch from Tim. I have tried to address > the comments/concerns from that request into the third revision. > > > Diffs > ----- > > src/master/flags.hpp 5e9ecb5 > src/master/master.hpp c9f989a > src/master/master.cpp 18464ba > src/tests/master_tests.cpp 9de2424 > > Diff: https://reviews.apache.org/r/22066/diff/ > > > Testing > ------- > > Added one more test after Tim's patch to test offer is not rescinded once it > has been declined. > > make check > > > Thanks, > > Kapil Arya > >
