----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22066/#review51478 -----------------------------------------------------------
src/master/flags.hpp <https://reviews.apache.org/r/22066/#comment89831> Rather than relying on Duration::zero() as a special value indicating no timeout, let's encode this via an Option<Duration> as we've done with other optional flags. :) Then we can also validate the flag, expecting that if it is provided, it is strictly greater than Duration::zero(). - Ben Mahler On Aug. 20, 2014, 1:54 a.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22066/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2014, 1:54 a.m.) > > > Review request for mesos, Adam B, Ben Mahler, Niklas Nielsen, and Timothy > Chen. > > > Bugs: mesos-186 > https://issues.apache.org/jira/browse/mesos-186 > > > Repository: mesos-git > > > Description > ------- > > A timer is associated with each newly created offer. > The offer is rescinded on timeout. > The timer is disarmed on a launchTask or decline. > > This is continuation of Tim's patch: https://reviews.apache.org/r/22796/. > Revision two represents the latest patch from Tim. I have tried to address > the comments/concerns from that request into the third revision. > > > Diffs > ----- > > src/master/flags.hpp 5e9ecb5 > src/master/master.hpp c9f989a > src/master/master.cpp 18464ba > src/tests/master_tests.cpp 9de2424 > > Diff: https://reviews.apache.org/r/22066/diff/ > > > Testing > ------- > > Added one more test after Tim's patch to test offer is not rescinded once it > has been declined. > > make check > > > Thanks, > > Kapil Arya > >
