----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25270/#review52158 -----------------------------------------------------------
What's the reason for not also supporting the `port` resource type? For example, the Hadoop framework uses this https://github.com/mesos/hadoop/blob/master/src/main/java/org/apache/hadoop/mapred/ResourcePolicy.java#L458-L472. I noticed there's a TODO here https://github.com/apache/mesos/blob/master/src/docker/docker.cpp#L256 to support the ports resource. I think it'd be nice to support both this kind of PortMapping behaviour for explicit mappings, as you've done in the DockerInfo protobuf, but if I just need any old port that's available to bind to a resource type would be useful. - Tom Arnfeld On Sept. 2, 2014, 8:47 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25270/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2014, 8:47 p.m.) > > > Review request for mesos, Benjamin Hindman and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > Enable bridge networking and port mapping for Docker > > > Diffs > ----- > > include/mesos/mesos.proto dea51f9 > src/docker/docker.cpp af51ac9 > src/slave/slave.cpp 5c76dd1 > src/tests/docker_containerizer_tests.cpp 8654f9c > > Diff: https://reviews.apache.org/r/25270/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
