> On Sept. 4, 2014, 8:23 p.m., Timothy St. Clair wrote: > > src/docker/docker.cpp, line 324 > > <https://reviews.apache.org/r/25270/diff/1/?file=674166#file674166line324> > > > > Don't you want --host= and --bridge=br(x), in the case where folks > > configure bridges for vlans?
Hi Tim, the custom bridge configuration is an option for the docker daemon, and not part of the per docker run configuration. So users want to configure bridges will set it on the docker daemon and docker cli will automatically pick it up. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25270/#review52347 ----------------------------------------------------------- On Sept. 4, 2014, 8:34 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25270/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2014, 8:34 p.m.) > > > Review request for mesos, Benjamin Hindman, Jie Yu, and Timothy St. Clair. > > > Bugs: MESOS-1621 > https://issues.apache.org/jira/browse/MESOS-1621 > > > Repository: mesos-git > > > Description > ------- > > Enable bridge networking and port mapping for Docker > > > Diffs > ----- > > include/mesos/mesos.proto dea51f9 > src/docker/docker.cpp af51ac9 > src/slave/slave.cpp 5c76dd1 > src/tests/docker_containerizer_tests.cpp 8654f9c > > Diff: https://reviews.apache.org/r/25270/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
