----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25344/#review52378 -----------------------------------------------------------
Ship it! Thanks! src/linux/cgroups.cpp <https://reviews.apache.org/r/25344/#comment91150> Maybe we shouldn't ignore the transition of the future here, instead we can map: ready -> ready failed -> failed discarded -> failed("Timed out in ..."); I think timedout is two words :) src/linux/cgroups.cpp <https://reviews.apache.org/r/25344/#comment91151> Could you use an Owned to avoid the need for deleting the promise explicitly? - Ben Mahler On Sept. 4, 2014, 11:12 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25344/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2014, 11:12 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/linux/cgroups.cpp 989e307a3483f2ec419aa12f7769bc107d5ac4d4 > src/slave/containerizer/linux_launcher.cpp > f3cc813c64e9298f43c9691de9d51ba29c3a8e91 > src/slave/containerizer/mesos/containerizer.cpp > 5116b14b312b6d605245486f33b74d2547287876 > > Diff: https://reviews.apache.org/r/25344/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
