-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25344/#review52380
-----------------------------------------------------------

Ship it!



src/linux/cgroups.cpp
<https://reviews.apache.org/r/25344/#comment91154>

    const Owned& ?



src/linux/cgroups.cpp
<https://reviews.apache.org/r/25344/#comment91155>

    s/Nothing()/future.get()/ ?



src/linux/cgroups.cpp
<https://reviews.apache.org/r/25344/#comment91157>

    s/in/after/ ?



src/linux/cgroups.cpp
<https://reviews.apache.org/r/25344/#comment91158>

    s/_future/future_/ akin to prime notation


- Ben Mahler


On Sept. 4, 2014, 11:47 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25344/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2014, 11:47 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.cpp 989e307a3483f2ec419aa12f7769bc107d5ac4d4 
>   src/slave/containerizer/isolators/cgroups/perf_event.cpp 
> 6f65b722c5b22a71a7c334c2b63db1584cb9fe29 
>   src/slave/containerizer/linux_launcher.cpp 
> f3cc813c64e9298f43c9691de9d51ba29c3a8e91 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 5116b14b312b6d605245486f33b74d2547287876 
> 
> Diff: https://reviews.apache.org/r/25344/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to