> On Sept. 15, 2014, 12:44 a.m., Bhuvan Arumugam wrote: > > src/tests/docker_containerizer_tests.cpp, line 243 > > <https://reviews.apache.org/r/25270/diff/5/?file=685937#file685937line243> > > > > Timothy Chen: do you intend to use the image mesosphere/test-executor?
No I actually intend to use the new image, I don't have access to update that image so I created a new one. The test-executor is a native go implementation of the api, and was lacking what libprocess was doing which is to publish PID with publish host ip, and it used to only subscribe as 0.0.0.0 which won't work with bridge network. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25270/#review53298 ----------------------------------------------------------- On Sept. 11, 2014, 5:48 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25270/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2014, 5:48 p.m.) > > > Review request for mesos, Benjamin Hindman, Jie Yu, and Timothy St. Clair. > > > Bugs: MESOS-1621 > https://issues.apache.org/jira/browse/MESOS-1621 > > > Repository: mesos-git > > > Description > ------- > > Review: https://reviews.apache.org/r/25270 > > > Diffs > ----- > > include/mesos/mesos.proto dea51f94d130c131421c43e7fd774ceb8941f501 > src/docker/docker.cpp af51ac9058382aede61b09e06e312ad2ce6de03e > src/slave/slave.cpp 1b3dc7370a2441e4159aa5ee552b64ca5e511e96 > src/tests/docker_containerizer_tests.cpp > 8654f9c787bd207f6a7b821651e0c083bea9dc8a > src/tests/docker_tests.cpp 826a8c1ef1b3089d416e5775fa2cf4e5cb0c26d1 > > Diff: https://reviews.apache.org/r/25270/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
