> On Sept. 9, 2014, 6:48 p.m., Benjamin Hindman wrote: > > include/mesos/mesos.proto, line 860 > > <https://reviews.apache.org/r/25270/diff/4/?file=680517#file680517line860> > > > > Any reason not to do s/NetworkMode/Network/ instead?
Not really, I thought Network seems a bit too generic and thought to reserve that word perhaps for something else. But Network is fine too. > On Sept. 9, 2014, 6:48 p.m., Benjamin Hindman wrote: > > include/mesos/mesos.proto, line 870 > > <https://reviews.apache.org/r/25270/diff/4/?file=680517#file680517line870> > > > > Do you want to make this an enum too? Maybe not, but what happens if > > someone puts in 'TCP' instead of 'tcp'? I originally have this as an enum, but I discussed with Gabriel and he told me that there are talks for Docker to have custom protocol to be passed in and he suggested me to leave it as a string for more flexibility for the future. I will be lowercasing the protocol in mesos. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25270/#review52764 ----------------------------------------------------------- On Sept. 5, 2014, 4:55 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25270/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2014, 4:55 p.m.) > > > Review request for mesos, Benjamin Hindman, Jie Yu, and Timothy St. Clair. > > > Bugs: MESOS-1621 > https://issues.apache.org/jira/browse/MESOS-1621 > > > Repository: mesos-git > > > Description > ------- > > Review: https://reviews.apache.org/r/25270 > > > Diffs > ----- > > include/mesos/mesos.proto dea51f94d130c131421c43e7fd774ceb8941f501 > src/common/resources.cpp 29fc765f1a4c023d91e348cacd5b6333d351a5ac > src/docker/docker.cpp af51ac9058382aede61b09e06e312ad2ce6de03e > src/slave/slave.cpp bd31831022c97e68b0293d66e1eb5f28ac508525 > src/tests/docker_containerizer_tests.cpp > 8654f9c787bd207f6a7b821651e0c083bea9dc8a > src/tests/docker_tests.cpp 826a8c1ef1b3089d416e5775fa2cf4e5cb0c26d1 > > Diff: https://reviews.apache.org/r/25270/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >