> On Sept. 17, 2014, 6:32 p.m., Dominic Hamon wrote: > > I'm not convinced that this is necessarily the way we want to go, given the > > benefits of move semantics in modern compilers, but for consistency we can > > ship this until we have proof that performance favours the alternative.
Isn't move construction more expensive than const reference? - Kamil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25735/#review53688 ----------------------------------------------------------- On Sept. 17, 2014, 4:25 p.m., Kamil Domanski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25735/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2014, 4:25 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-1805 > https://issues.apache.org/jira/browse/MESOS-1805 > > > Repository: mesos-git > > > Description > ------- > > os::shell and an overload of strings::internal::fmt in stout pass a const > string parameter by copy instead of reference. This patch fixes that. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 58ab742 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/shell.hpp 6728ad8 > > Diff: https://reviews.apache.org/r/25735/diff/ > > > Testing > ------- > > cd 3rdparty/libprocess/3rdparty/ && make check > > > Thanks, > > Kamil Domanski > >
