----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25735/#review59068 -----------------------------------------------------------
We can't make these `const-ref` unfortunately because the second argument of `va_start` cannot be a reference type. N3797: 18.10 Other runtime support [support.runtime] The restrictions that ISO C places on the second parameter to the va_start() macro in header <stdarg.h> are different in this International Standard. The parameter parmN is the identifier of the rightmost parameter in the variable parameter list of the function definition (the one just before the ...). __If the parameter parmN is of a reference type, or of a type that is not compatible with the type that results when passing an argument for which there is no parameter, the behavior is undefined.__ - Michael Park On Sept. 17, 2014, 2:25 p.m., Kamil Domanski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25735/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2014, 2:25 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-1805 > https://issues.apache.org/jira/browse/MESOS-1805 > > > Repository: mesos-git > > > Description > ------- > > os::shell and an overload of strings::internal::fmt in stout pass a const > string parameter by copy instead of reference. This patch fixes that. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 58ab742 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/shell.hpp 6728ad8 > > Diff: https://reviews.apache.org/r/25735/diff/ > > > Testing > ------- > > cd 3rdparty/libprocess/3rdparty/ && make check > > > Thanks, > > Kamil Domanski > >
