----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25448/#review53857 -----------------------------------------------------------
m4/ax_cxx_compile_stdcxx_11.m4 <https://reviews.apache.org/r/25448/#comment93721> Why specify these at all? The defaults would be good enough for testing purposes. Even if we specify them, why not use '= default'? m4/ax_cxx_compile_stdcxx_11.m4 <https://reviews.apache.org/r/25448/#comment93723> It would be good to probably have an assert or two here to ensure the move worked. assert(!p2); assert(p1); - Cody Maloney On Sept. 8, 2014, 5:30 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25448/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2014, 5:30 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-1771 > https://issues.apache.org/jira/browse/MESOS-1771 > > > Repository: mesos-git > > > Description > ------- > > Add check to configure script for std::unique_ptr and std::move > > > Diffs > ----- > > m4/ax_cxx_compile_stdcxx_11.m4 07b298f151094e818287f741b3e0efd28374e82b > > Diff: https://reviews.apache.org/r/25448/diff/ > > > Testing > ------- > > make check with g++-4.4 and clang++ (3.5) > > > Thanks, > > Dominic Hamon > >
