> On Sept. 18, 2014, 12:56 p.m., Cody Maloney wrote: > > m4/ax_cxx_compile_stdcxx_11.m4, line 76 > > <https://reviews.apache.org/r/25448/diff/1/?file=682725#file682725line76> > > > > It would be good to probably have an assert or two here to ensure the > > move worked. > > assert(!p2); > > assert(p1);
true, except the check only compiles the code. i've simplified further with that in mind (the if checks are unnecessary). - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25448/#review53857 ----------------------------------------------------------- On Sept. 19, 2014, 10:48 a.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25448/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2014, 10:48 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-1771 > https://issues.apache.org/jira/browse/MESOS-1771 > > > Repository: mesos-git > > > Description > ------- > > Add check to configure script for std::unique_ptr and std::move > > > Diffs > ----- > > m4/ax_cxx_compile_stdcxx_11.m4 d4b662827b2d705feb71902bdc006ce14775fa95 > > Diff: https://reviews.apache.org/r/25448/diff/ > > > Testing > ------- > > make check with g++-4.4 and clang++ (3.5) > > > Thanks, > > Dominic Hamon > >
