> On Sept. 18, 2014, 8:11 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp, line 190 > > <https://reviews.apache.org/r/25789/diff/1/?file=693848#file693848line190> > > > > given that we test for variadic template support in configure, do you > > think we still need this?
I'm on board with not checking this anymore as long as everyone is on board with that. - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25789/#review53862 ----------------------------------------------------------- On Sept. 18, 2014, 7:58 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25789/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2014, 7:58 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > Add Variadic strings join for c++11 and above. > There is a second version of the variadic join which takes a reference to a > stringstream as a parameter. This is handy when strings::join is just a part > of a larger string manipulation. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp a1702cd > 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 51008e5 > > Diff: https://reviews.apache.org/r/25789/diff/ > > > Testing > ------- > > Ran make check for stout. Added test cases for join as these were missing. > > > Thanks, > > Joris Van Remoortere > >