----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25789/ -----------------------------------------------------------
(Updated Sept. 19, 2014, 6:37 p.m.) Review request for mesos and Benjamin Hindman. Changes ------- Add overloads of an internal::append function to support mixed type strings::join(). There are special overloads for string ands const char * to maintain performance. Added a test for mixed type strings::join(). Fixed style issues. Repository: mesos-git Description ------- Add Variadic strings join for c++11 and above. There is a second version of the variadic join which takes a reference to a stringstream as a parameter. This is handy when strings::join is just a part of a larger string manipulation. Diffs (updated) ----- 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp a1702cd 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 51008e5 Diff: https://reviews.apache.org/r/25789/diff/ Testing ------- Ran make check for stout. Added test cases for join as these were missing. Thanks, Joris Van Remoortere
