> On Sept. 16, 2014, 6:44 a.m., Vinod Kone wrote: > > src/tests/master_tests.cpp, line 2329 > > <https://reviews.apache.org/r/25568/diff/1/?file=687338#file687338line2329> > > > > What is the guarantee that offers2 will be made after task's resources > > are recovered?
I forgot to pass the resource flags for the slave in per your comment above. The gaurantee is now that we use the full offer, so no resources remain. If we ever break that guarantee, we'll catch it here and the test would fail: ``` // Ensure we get all of the resources back. EXPECT_EQ(offers1.get()[0].resources(), offers2.get()[0].resources()); ``` I also added a Clock::advance to avoid waiting around for the allocation interval. > On Sept. 16, 2014, 6:44 a.m., Vinod Kone wrote: > > src/tests/reconciliation_tests.cpp, lines 734-735 > > <https://reviews.apache.org/r/25568/diff/1/?file=687339#file687339line734> > > > > Why do you want to make sure that master received the reconcile tasks > > message? Isn't the receipt of the update guarantee that? > > > > Actually, thinking a bit more, how do you guarantee that the second > > update was due to reconcile tasks and not a retry by the slave? Removed this, was an artifact of needing Clock::settle from other tests. I've now made it so that only the first StatusUpdateMessage from slave to master is delivered. All other StatusUpdateMessages will be dropped (confirmed this worked by temporarily adding a Clock::advance() loop to force the slave to retry). - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25568/#review53484 ----------------------------------------------------------- On Sept. 12, 2014, 2:01 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25568/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2014, 2:01 a.m.) > > > Review request for mesos, Niklas Nielsen and Vinod Kone. > > > Bugs: MESOS-1410 > https://issues.apache.org/jira/browse/MESOS-1410 > > > Repository: mesos-git > > > Description > ------- > > Added two tests: > > (1) Ensure that reconciliation works for terminal unacknowledged tasks. > (2) Ensure that resources are released for terminal unacknowledged tasks. > > > Diffs > ----- > > src/master/master.cpp d5db24ef3c2d2501aa5852b62d50a425bc0ad925 > src/tests/master_tests.cpp 3d080b2efad5a210353d4cef4c827380d5138d1a > src/tests/reconciliation_tests.cpp 1c9e73b0ee99a8a33f663f992b0c9770e83b98c5 > > Diff: https://reviews.apache.org/r/25568/diff/ > > > Testing > ------- > > make check, ran these new tests in repetition > > > Thanks, > > Ben Mahler > >
