----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25568/#review53902 -----------------------------------------------------------
Ship it! src/tests/reconciliation_tests.cpp <https://reviews.apache.org/r/25568/#comment93766> s/we do this// ? - Vinod Kone On Sept. 18, 2014, 9:30 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25568/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2014, 9:30 p.m.) > > > Review request for mesos, Niklas Nielsen and Vinod Kone. > > > Bugs: MESOS-1410 > https://issues.apache.org/jira/browse/MESOS-1410 > > > Repository: mesos-git > > > Description > ------- > > Added two tests: > > (1) Ensure that reconciliation works for terminal unacknowledged tasks. > (2) Ensure that resources are released for terminal unacknowledged tasks. > > > Diffs > ----- > > src/master/master.cpp 52a7409f7132f89f4a64e589fa096dd07f527fd9 > src/tests/master_tests.cpp ff2b50f517d7c413419e6c7bc823cf5e2cdff1aa > src/tests/reconciliation_tests.cpp 1c9e73b0ee99a8a33f663f992b0c9770e83b98c5 > > Diff: https://reviews.apache.org/r/25568/diff/ > > > Testing > ------- > > make check, ran these new tests in repetition > > > Thanks, > > Ben Mahler > >
