-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25847/#review54018
-----------------------------------------------------------



3rdparty/libprocess/include/process/node.hpp
<https://reviews.apache.org/r/25847/#comment93890>

    worth renaming to IpPort? or Host?



3rdparty/libprocess/include/process/node.hpp
<https://reviews.apache.org/r/25847/#comment93888>

    uint64_t?
    
    start getting ipv6 support in... ;)


- Dominic Hamon


On Sept. 19, 2014, 1:31 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25847/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2014, 1:31 p.m.)
> 
> 
> Review request for mesos and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Move class Node out of process.cpp and into its own header.
> Part of refactoring process.cpp.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/Makefile.am 09f6e41 
>   3rdparty/libprocess/include/process/node.hpp PRE-CREATION 
>   3rdparty/libprocess/src/process.cpp 3ac56c7 
> 
> Diff: https://reviews.apache.org/r/25847/diff/
> 
> 
> Testing
> -------
> 
> make check in libprocess
> support/mesos-stype.py
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Reply via email to