----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25847/#review54030 -----------------------------------------------------------
Ship it! Can you motivate it a bit in context of eventually reworking the libprocess transport/event: https://issues.apache.org/jira/browse/MESOS-1330 and down-sizing the 4000+ line process.cpp :-) 3rdparty/libprocess/include/process/node.hpp <https://reviews.apache.org/r/25847/#comment93927> Know it is not yours, but these fit on a single line. Thanks! :) We try to use postfix underscore now to avoid clashes, https://www.gnu.org/software/libc/manual/html_node/Reserved-Names.html I will leave that up to you whether you want to address it here. - Niklas Nielsen On Sept. 19, 2014, 1:31 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25847/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2014, 1:31 p.m.) > > > Review request for mesos and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Move class Node out of process.cpp and into its own header. > Part of refactoring process.cpp. > > > Diffs > ----- > > 3rdparty/libprocess/include/Makefile.am 09f6e41 > 3rdparty/libprocess/include/process/node.hpp PRE-CREATION > 3rdparty/libprocess/src/process.cpp 3ac56c7 > > Diff: https://reviews.apache.org/r/25847/diff/ > > > Testing > ------- > > make check in libprocess > support/mesos-stype.py > > > Thanks, > > Joris Van Remoortere > >
