----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25868/#review54086 -----------------------------------------------------------
Thanks Joris! Any reason you want this exposed in the public include/ folder of libprocess, as opposed to an internal header inside src/? Don't think we'd want this in the public includes. - Ben Mahler On Sept. 20, 2014, 12:58 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25868/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2014, 12:58 a.m.) > > > Review request for mesos and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Move class ProcessReference out of process.cpp and into its own header. > Part of refactoring process.cpp. > > > Diffs > ----- > > 3rdparty/libprocess/include/Makefile.am 542ae1c > 3rdparty/libprocess/include/process/process_reference.hpp PRE-CREATION > 3rdparty/libprocess/src/process.cpp 8adc809 > > Diff: https://reviews.apache.org/r/25868/diff/ > > > Testing > ------- > > make check in 3rdparty/libprocess > support/mesos-style.py > > > Thanks, > > Joris Van Remoortere > >