> On Sept. 20, 2014, 12:22 p.m., Ben Mahler wrote: > > Thanks Joris! > > > > Any reason you want this exposed in the public include/ folder of > > libprocess, as opposed to an internal header inside src/? Don't think we'd > > want this in the public includes.
It seems to be a bit unconsistent whether things have gone in include/ or not. For example, the socket abstraction is only used by libprocess internally and is in include/. The node class ended up there too (my / our fault) - so if we decide to move the private headers to src/, we need to move that alongside doing a scan for the headers we only use inside libprocess. - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25868/#review54086 ----------------------------------------------------------- On Sept. 19, 2014, 5:58 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25868/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2014, 5:58 p.m.) > > > Review request for mesos and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Move class ProcessReference out of process.cpp and into its own header. > Part of refactoring process.cpp. > > > Diffs > ----- > > 3rdparty/libprocess/include/Makefile.am 542ae1c > 3rdparty/libprocess/include/process/process_reference.hpp PRE-CREATION > 3rdparty/libprocess/src/process.cpp 8adc809 > > Diff: https://reviews.apache.org/r/25868/diff/ > > > Testing > ------- > > make check in 3rdparty/libprocess > support/mesos-style.py > > > Thanks, > > Joris Van Remoortere > >
