----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25867/#review54240 -----------------------------------------------------------
Patch looks great! Reviews applied: [25866, 25867] All tests passed. - Mesos ReviewBot On Sept. 22, 2014, 11:51 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25867/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2014, 11:51 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1668 > https://issues.apache.org/jira/browse/MESOS-1668 > > > Repository: mesos-git > > > Description > ------- > > Embeded slave registration status in ping message to solicit slave > re-registration during one way master --> slave partition. > > > Diffs > ----- > > src/Makefile.am 9b973e5503e30180045e270220987ba647da8038 > src/master/master.cpp e5d30e9c7ba1ec0cdd640c81610790f3397f3062 > src/messages/messages.proto 7cb3ce651997c04ef1ef95539098ed2a99270b11 > src/slave/slave.hpp 4f3df5c49a8cf72fc7153158c9eb045196b6cf13 > src/slave/slave.cpp 28eb02852ddcc10efe589a8069dba9c895bc160e > src/tests/partition_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/25867/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >