> On Sept. 25, 2014, 12:30 a.m., Ben Mahler wrote: > > src/master/master.cpp, line 1746 > > <https://reviews.apache.org/r/25867/diff/3/?file=700965#file700965line1746> > > > > You don't need the `->self()` here and below, dispatch can take a > > pointer to do it for you.
thanks! > On Sept. 25, 2014, 12:30 a.m., Ben Mahler wrote: > > src/master/master.cpp, line 179 > > <https://reviews.apache.org/r/25867/diff/3/?file=700965#file700965line179> > > > > Generally I get a bit worried about these versioned TODO's unless we > > have tickets with the correct Target/Fix Version to make sure we follow up. > > Will you create tickets when this lands? > > > > Otherwise we'll most definitely forget! Definitely. I'll add them shortly. > On Sept. 25, 2014, 12:30 a.m., Ben Mahler wrote: > > src/tests/partition_tests.cpp, lines 107-109 > > <https://reviews.apache.org/r/25867/diff/3/?file=700969#file700969line107> > > > > Couldn't you just expect the dispatch on SlaveObserver::disconnect, > > instead of the allocator dispatch + clock::settle? SlaveObserver is private. Didn't want to make it public. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25867/#review54480 ----------------------------------------------------------- On Sept. 22, 2014, 11:51 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25867/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2014, 11:51 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1668 > https://issues.apache.org/jira/browse/MESOS-1668 > > > Repository: mesos-git > > > Description > ------- > > Embeded slave registration status in ping message to solicit slave > re-registration during one way master --> slave partition. > > > Diffs > ----- > > src/Makefile.am 9b973e5503e30180045e270220987ba647da8038 > src/master/master.cpp e5d30e9c7ba1ec0cdd640c81610790f3397f3062 > src/messages/messages.proto 7cb3ce651997c04ef1ef95539098ed2a99270b11 > src/slave/slave.hpp 4f3df5c49a8cf72fc7153158c9eb045196b6cf13 > src/slave/slave.cpp 28eb02852ddcc10efe589a8069dba9c895bc160e > src/tests/partition_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/25867/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
