----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25922/#review54251 -----------------------------------------------------------
Patch looks great! Reviews applied: [25922] All tests passed. - Mesos ReviewBot On Sept. 23, 2014, 2:50 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25922/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2014, 2:50 a.m.) > > > Review request for mesos, Adam B and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > Following from: r25105 > Currently there is no disk isolation in place and this affects an executor to > be starved of disk when another disk heavy operation such as copying a multi > gigabyte file is being performed by another executor. > > > Diffs > ----- > > include/mesos/mesos.proto be45494 > include/mesos/resources.hpp 0e37170 > src/Makefile.am 9b973e5 > src/common/resources.cpp e9a0c85 > src/linux/cgroups.hpp abf31df > src/linux/cgroups.cpp 5093b4c > src/slave/containerizer/isolators/cgroups/blkio.hpp PRE-CREATION > src/slave/containerizer/isolators/cgroups/blkio.cpp PRE-CREATION > src/slave/containerizer/mesos/containerizer.cpp 9d08329 > src/tests/isolator_tests.cpp c38f876 > > Diff: https://reviews.apache.org/r/25922/diff/ > > > Testing > ------- > > make check > sudo bin/mesos-tests.sh --gtest_filter="*BlkIO*" > support/mesos-style.py > > > Thanks, > > Joris Van Remoortere > >
