----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25922/#review54343 -----------------------------------------------------------
This work should be split into: 1. A blkio isolator that only provides block device usage statistics and does *not* enforce any limits. This is independently useful to understand the usage of tasks, and to guide decisions on what limits would be set. 2. Enhance the isolator to limit block device usage. This requires not only support from the isolator (as done in this review) but also elevating block device capabilities to a first class resource, i.e., specifying in each slave's resources, passing this to the master, including it in the allocator, and making it accessible to frameworks. This latter functionality is not addressed in this review but is necessary for limits to be used. This would benefit from some discussion; could you please write up a design doc on the blkio isolator and make it accessible from the JIRA ticket? - Ian Downes On Sept. 22, 2014, 7:50 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25922/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2014, 7:50 p.m.) > > > Review request for mesos, Adam B and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > Following from: r25105 > Currently there is no disk isolation in place and this affects an executor to > be starved of disk when another disk heavy operation such as copying a multi > gigabyte file is being performed by another executor. > > > Diffs > ----- > > include/mesos/mesos.proto be45494 > include/mesos/resources.hpp 0e37170 > src/Makefile.am 9b973e5 > src/common/resources.cpp e9a0c85 > src/linux/cgroups.hpp abf31df > src/linux/cgroups.cpp 5093b4c > src/slave/containerizer/isolators/cgroups/blkio.hpp PRE-CREATION > src/slave/containerizer/isolators/cgroups/blkio.cpp PRE-CREATION > src/slave/containerizer/mesos/containerizer.cpp 9d08329 > src/tests/isolator_tests.cpp c38f876 > > Diff: https://reviews.apache.org/r/25922/diff/ > > > Testing > ------- > > make check > sudo bin/mesos-tests.sh --gtest_filter="*BlkIO*" > support/mesos-style.py > > > Thanks, > > Joris Van Remoortere > >
