----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25789/#review54463 -----------------------------------------------------------
The last nits: looks good to me, but would like BenH to take a look :) 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp <https://reviews.apache.org/r/25789/#comment94605> How about renaming ss to 'stream' or something more descriptive? (Here and below) 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp <https://reviews.apache.org/r/25789/#comment94606> Same for 'val' - let's expand it to a full word. Here and below 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp <https://reviews.apache.org/r/25789/#comment94604> should be 4 space indent. - Niklas Nielsen On Sept. 23, 2014, 10:30 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25789/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2014, 10:30 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > Add Variadic strings join. > There is a second version of the variadic join which takes a reference to a > stringstream as a parameter. This is handy when strings::join is just a part > of a larger string manipulation. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp a1702cd > 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 51008e5 > > Diff: https://reviews.apache.org/r/25789/diff/ > > > Testing > ------- > > Ran make check for stout. Added test cases for join as these were missing. > > > Thanks, > > Joris Van Remoortere > >
